Fix spinner/progress hanging on error during download#14
Merged
RichardBray merged 3 commits intomainfrom Feb 13, 2026
Merged
Conversation
Clear the terminal line before printing error messages so the spinner or progress indicator doesn't remain visible after failures. Also release the stream reader in a finally block to prevent the process from hanging on mid-download errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Tests cover HLS download, custom output path, invalid URL handling, non-video tweets, spinner cleanup, and orphan process detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add project guide for Claude Code with build instructions and local testing workflow. Decouple spinner animation (80ms) from file-size polling (2s) so the spinner actually visibly spins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\r\x1b[K) before printing error messages on all failure paths inffmpeg.ts,downloader.ts, andindex.tsfinallyblock indownloader.tsto prevent the process from hanging when a mid-download error occursdocs/to.gitignoreTest plan
🤖 Generated with Claude Code